Basic validation for imagetype for NVME enabled instances #5660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
cncf-cla: yes
|
Thanks @geojaz! This is a good starting spot. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geojaz, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Aug 18, 2018
mikesplain
added a commit
to mikesplain/test-infra
that referenced
this pull request
Aug 29, 2018
We now error on m5 usage unless stretch image is specified kubernetes/kops#5660
prichrd
reviewed
Oct 1, 2018
| // TODO: make image validation smarter? graduate from jessie to stretch? This is quick and dirty because we keep getting reports | ||
| func awsValidateAMIforNVMe(fieldPath *field.Path, ig *kops.InstanceGroup) field.ErrorList { | ||
| // TODO: how can we put this list somewhere better? | ||
| NVMe_INSTANCE_PREFIXES := []string{"P3", "C5", "M5", "H1", "I3"} |
There was a problem hiding this comment.
@geojaz is it possible that this slice is missing the R5 instance family? https://aws.amazon.com/ec2/instance-types/r5/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #5653