Adds some basic validation to encourage running 5th gen instances on stretch #5653
Conversation
… in the name) if you're using instances with NVMe
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geojaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
|
||
| // TODO: make image validation smarter? graduate from jessie to stretch? This is quick and dirty because we keep getting reports | ||
| func awsValidateAMIforNVMe(fieldPath *field.Path, ig *kops.InstanceGroup) field.ErrorList { | ||
| NVMe_INSTANCE_PREFIXES := []string{"P3", "C5", "M5", "H1"} |
There was a problem hiding this comment.
I believe i3’s are also NVME
There was a problem hiding this comment.
I didn't mean to push this to kubernetes org :/ will fix this point and reopen. Any ideas for a better place to list these types of instances? this is already hard to maintain. I am not aware of any other lists of instances that have this type of metadata hanging around. Would adding something like that to the machinetypes list be better?
I hope this is a validation that we do not need to do for too much longer.
There was a problem hiding this comment.
@geojaz Agreed. We certainly could have a NVME flag in machinetypes, just like we do for gpu? That said, hopefully we don't need it much longer, it may not be worth implementing there
There was a problem hiding this comment.
yeah, I punted on getting this into 1.10, and the next day I had two colleagues come to me with this exact problem. people are definitely running into it, so i think having at least something to explain why things are going wrong is beneficial.
Ie: won't let you launch an m5.large with
kope.io/k8s-1.10-debian-jessie-*Should close #5175, #5520Consider this a first step towards more intelligent image type validation. it's just to give me context when things go wrong at this point.