etcd: introduce field to specify whether we are using etcd-manager or legacy mode #5820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
justinsb
force-pushed
the
etcd_manager_channels_step1
branch
2 times, most recently
from
d6d80c8
to
5170bed
Compare
k8s-ci-robot
added
size/L
|
/retest |
justinsb
force-pushed
the
etcd_manager_channels_step1
branch
from
5170bed
to
33e1288
Compare
|
/test pull-kops-e2e-kubernetes-aws |
|
/test pull-kops-e2e-kubernetes-aws |
|
This (hopefully) just needs mapping of the hot-off-the-presses 3.2.24, which I'm working on here: kopeio/etcd-manager#128 |
…y mode Splitting this out from the bigger bundle PR
justinsb
force-pushed
the
etcd_manager_channels_step1
branch
from
33e1288
to
54c499f
Compare
justinsb
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Updated etcd-manager image and this is now passing tests :-) |
chrislovecnm
reviewed
Oct 2, 2018
pkg/model/components/etcd.go
Outdated
| if c.Version == "" && c.Provider == kops.EtcdProviderTypeLegacy { | ||
| // Even if in legacy mode, etcd version 2 is unsupported as of k8s 1.13 | ||
| if b.IsKubernetesGTE("1.13") { | ||
| c.Version = "3.2.24" |
There was a problem hiding this comment.
Should we make this another const to follow the same pattern as etcd2
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting this out from the bigger bundle PR