New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove etcd2 storage backend #69310

Merged
merged 2 commits into from Oct 4, 2018

Conversation

@liggitt
Member

liggitt commented Oct 1, 2018

What this PR does / why we need it:
Removes the deprecated etcd2 backend

Which issue(s) this PR fixes:
xref kubernetes/features#622

Special notes for your reviewer:

Release note:

kube-apiserver has removed support for the `etcd2` storage backend (deprecated since v1.9). Existing clusters must migrate etcd v2 data to etcd v3 storage before upgrading to v1.13.

cc @kubernetes/sig-api-machinery-pr-reviews @kubernetes/sig-cluster-lifecycle-pr-reviews

/assign @lavalamp @deads2k

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Oct 1, 2018

Member

cc @kubernetes/sig-testing-pr-reviews for impact on test jobs
cc @justinsb

Member

liggitt commented Oct 1, 2018

cc @kubernetes/sig-testing-pr-reviews for impact on test jobs
cc @justinsb

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Oct 1, 2018

Member

holding to make sure there are no CI jobs still intentionally starting on etcd2 for test signal (kubernetes/test-infra#7602)

Member

liggitt commented Oct 1, 2018

holding to make sure there are no CI jobs still intentionally starting on etcd2 for test signal (kubernetes/test-infra#7602)

@liggitt liggitt added this to the v1.13 milestone Oct 1, 2018

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Oct 1, 2018

Member

/kind cleanup

Member

liggitt commented Oct 1, 2018

/kind cleanup

@fejta

This comment has been minimized.

Show comment
Hide comment
@fejta

fejta Oct 1, 2018

Contributor

Do we still have tests that run on etcd2? Is plan to remove them before or after this? And awesome btw :)

Contributor

fejta commented Oct 1, 2018

Do we still have tests that run on etcd2? Is plan to remove them before or after this? And awesome btw :)

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Oct 1, 2018

Member

Do we still have tests that run on etcd2?

I don't know. The only tests we should have at this point are ones that specifically exist to ensure we continue to function on etcd2.

Is plan to remove them before or after this?

They should be removed before this merges.

Member

liggitt commented Oct 1, 2018

Do we still have tests that run on etcd2?

I don't know. The only tests we should have at this point are ones that specifically exist to ensure we continue to function on etcd2.

Is plan to remove them before or after this?

They should be removed before this merges.

@timothysc

/lgtm
/hold

per @fejta 's comment. Once someone cross-verifies test-grid feel free to cancel the hold.

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 1, 2018

@justinsb

This comment has been minimized.

Show comment
Hide comment
@justinsb

justinsb Oct 1, 2018

Member

The PRs to get kops not using etcd3 on 1.13 (actually we'll switch on 1.12) are in flight: kubernetes/kops#5820 Just need to update that for the new etcd version - 3.2.24 I believe.

We may be blocked on getting an etcd-management project going as a sig-cluster-lifecycle SIG project, so I'll work on that proposal also.

Member

justinsb commented Oct 1, 2018

The PRs to get kops not using etcd3 on 1.13 (actually we'll switch on 1.12) are in flight: kubernetes/kops#5820 Just need to update that for the new etcd version - 3.2.24 I believe.

We may be blocked on getting an etcd-management project going as a sig-cluster-lifecycle SIG project, so I'll work on that proposal also.

@BenTheElder

This comment has been minimized.

Show comment
Hide comment
@BenTheElder

BenTheElder Oct 1, 2018

Member

see: kubernetes/test-infra#7602

there are a few test-infra things to cleanup when we make the switch. cc @spiffxp

Member

BenTheElder commented Oct 1, 2018

see: kubernetes/test-infra#7602

there are a few test-infra things to cleanup when we make the switch. cc @spiffxp

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Oct 3, 2018

Member

/assign @wojtek-t
can you review the "Switch e2e_node to etcd3" commit?

Member

liggitt commented Oct 3, 2018

/assign @wojtek-t
can you review the "Switch e2e_node to etcd3" commit?

@liggitt liggitt changed the title from WIP: Remove etcd2 storage backend to Remove etcd2 storage backend Oct 3, 2018

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Oct 3, 2018

Member

presubmit tests are green

waiting on @wojtek-t for review of e2e node commit, and @spiffxp for ack that tests look good after kubernetes/test-infra#9672 merged

Member

liggitt commented Oct 3, 2018

presubmit tests are green

waiting on @wojtek-t for review of e2e node commit, and @spiffxp for ack that tests look good after kubernetes/test-infra#9672 merged

@wojtek-t

This comment has been minimized.

Show comment
Hide comment
@wojtek-t

wojtek-t Oct 3, 2018

Member

can you review the "Switch e2e_node to etcd3" commit?

This looks great.

/lgtm

Member

wojtek-t commented Oct 3, 2018

can you review the "Switch e2e_node to etcd3" commit?

This looks great.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 3, 2018

@wojtek-t

This comment has been minimized.

Show comment
Hide comment
@wojtek-t

wojtek-t Oct 3, 2018

Member

/hold

Since we want to wait for other tests results.
@liggitt - feel free to unhold it when you're ready.

Member

wojtek-t commented Oct 3, 2018

/hold

Since we want to wait for other tests results.
@liggitt - feel free to unhold it when you're ready.

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Oct 3, 2018

Member

/lgtm
I'm confident enough in what I've seen over the past 12 hours to say we're good to go. That said, I waited until overnight PT to let my changes merge, so I got N runs against the same commit. I'm suspect if we see anything as a result of this merging, it will be clear and immediate breakage, rather than flakiness and degredation. I leave it to @liggitt to remove the /hold when ready, and will keep on an on sig-release-master-blocking to start with

Member

spiffxp commented Oct 3, 2018

/lgtm
I'm confident enough in what I've seen over the past 12 hours to say we're good to go. That said, I waited until overnight PT to let my changes merge, so I got N runs against the same commit. I'm suspect if we see anything as a result of this merging, it will be clear and immediate breakage, rather than flakiness and degredation. I leave it to @liggitt to remove the /hold when ready, and will keep on an on sig-release-master-blocking to start with

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 3, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, liggitt, spiffxp, timothysc, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, liggitt, spiffxp, timothysc, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Oct 3, 2018

Member

/hold cancel

Member

liggitt commented Oct 3, 2018

/hold cancel

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Oct 3, 2018

Member

/retest

Member

liggitt commented Oct 3, 2018

/retest

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Oct 4, 2018

Member

/retest pull-kubernetes-e2e-kops-aws

Member

liggitt commented Oct 4, 2018

/retest pull-kubernetes-e2e-kops-aws

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 4, 2018

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 4, 2018

Contributor

New changes are detected. LGTM label has been removed.

Contributor

k8s-ci-robot commented Oct 4, 2018

New changes are detected. LGTM label has been removed.

@liggitt

This comment has been minimized.

Show comment
Hide comment
@liggitt

liggitt Oct 4, 2018

Member

rebased

Member

liggitt commented Oct 4, 2018

rebased

@liggitt liggitt added the lgtm label Oct 4, 2018

@spiffxp

This comment has been minimized.

Show comment
Hide comment
@spiffxp

spiffxp Oct 4, 2018

Member

/retest

Member

spiffxp commented Oct 4, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 409871e into kubernetes:master Oct 4, 2018

18 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:remove-etcd2 branch Oct 5, 2018

@spiffxp spiffxp referenced this pull request Oct 8, 2018

Open

Drop support for etcd2 #622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment