Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick of #5540 to release-1.10 #5881

Merged
merged 1 commit into from
Dec 22, 2018
Merged

Cherry pick of #5540 to release-1.10 #5881

merged 1 commit into from
Dec 22, 2018

Conversation

adammw
Copy link
Contributor

@adammw adammw commented Oct 5, 2018

Cherry pick of #5540 to release-1.10

Fixes #5537

@mikesplain @adammw
CloudProvider is defined in the Cluster Spec.
092becc 
CloudProvider can be set at the kubelet level, however
if the user overrides kubelet values, CloudProvider isn't always
set at this point, leading to an error.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 5, 2018
@adammw
Copy link
Contributor Author

adammw commented Oct 5, 2018

/assign @chrisz100

@chrisz100
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 16, 2018
chrisz100
chrisz100 approved these changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@chrisz100 chrisz100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @justinsb

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2018
@mikesplain
Copy link
Contributor

Not sure if this is necessary since this is included in the 1.11.0-alpha.1 which will likely be out quicker than another 1.10.

@adammw
Copy link
Contributor Author

adammw commented Oct 17, 2018

1.11 is still an alpha release however, and there are other changes in that release branch that increases the risk (e.g. tag removal which makes it no longer compatible with the nodeup from 1.10, etc.).

@justinsb
Copy link
Member

Low-risk bug fix, so approving!

/approve
/lgtm
/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adammw, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2018
@justinsb justinsb mentioned this pull request Dec 21, 2018
Closed
@rdrgmnzs
Copy link
Contributor

Tests have been really flaky

/test pull-kops-e2e-kubernetes-aws

@justinsb
Copy link
Member

It looks like this test is running against the k8s 1.13... (it's passing etcd-quorum-read)... will figure it out!

@justinsb
Copy link
Member

kubernetes/test-infra#10543 is for the e2e k8s skew issue

@justinsb
Copy link
Member

/retest

stable3 has appeared, so ... with luck :-)

@k8s-ci-robot
Copy link
Contributor

@adammw: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kops-e2e-kubernetes-aws 092becc link /test pull-kops-e2e-kubernetes-aws
pull-kops-e2e-kubernetes-aws-stable3 092becc link /test pull-kops-e2e-kubernetes-aws-stable3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justinsb
Copy link
Member

These failures are because I didn't set up the PR test job for 1.10 correctly, but it'll get tested post-merge anyway (every 6 hours). Force-merging!

@justinsb justinsb merged commit 4592bd5 into kubernetes:release-1.10 Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisz100 chrisz100 chrisz100 approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@justinsb justinsb

@chrisz100 chrisz100

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@adammw @chrisz100 @mikesplain @justinsb @k8s-ci-robot @rdrgmnzs