-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create kops e2e jobs for the older branches #10543
Create kops e2e jobs for the older branches #10543
Conversation
needs matching testgrid entries |
We were running kops 1.10 against k8s 1.13, which doesn't work as flags are removed. (Later versions of kops fix that, but kops is not forwards compatible).
4fd70e0
to
fa45c3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 32ebb0da484c21abf0d3f4f5fe53e50e9f10147b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@justinsb: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We were running kops 1.10 against k8s 1.13, which doesn't work as
flags are removed. (Later versions of kops fix that, but kops is not
forwards compatible).