Service Address Check #5923
Merged
Service Address Check #5923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation assumes you have specified a service address within your config rather than using being filled in by the defaults. This PR only checks when service address has been specified. Alternatively if people feel that this should be 'enforce' at the very least we should check the reference is not nil so we dont throw a panic.
k8s-ci-robot
added
size/XS
|
/assign @rdrgmnzs |
chrisz100
approved these changes
Oct 11, 2018
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisz100, gambol99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation assumes you have specified a service address within your config rather than using filled in defaults. This PR only checks when service address has been specified. Alternatively if people feel that this should be 'enforced', at the very least we should check the reference is not nil so we don't throw a panic.
Note, serviceClusterIPRange is set above here https://github.com/kubernetes/kops/blob/master/pkg/apis/kops/validation/legacy.go#L210