Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Address Check #5923

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Service Address Check #5923

merged 1 commit into from
Oct 11, 2018

Commits on Oct 11, 2018

  1. Service Address Check 

    The current implementation assumes you have specified a service address within your config rather than using being filled in by the defaults. This PR only checks when service address has been specified. Alternatively if people feel that this should be 'enforce' at the very least we should check the reference is not nil so we dont throw a panic.
    @gambol99
    gambol99 committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    fe07a81 View commit details
    Browse the repository at this point in the history