Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify license statement for nvidia-bootstrap hook #6006

Merged
merged 1 commit into from
Oct 27, 2018
Merged

Clarify license statement for nvidia-bootstrap hook #6006

merged 1 commit into from
Oct 27, 2018

Conversation

swinslow
Copy link
Contributor

This is meant to clarify a license statement in the nvidia-bootstrap hook's README file.

@vishh @justinsb This relates to our earlier discussion in steering: kubernetes/steering#57 (comment)

cc @nikhita

@swinslow
Clarify license statement for nvidia-bootstrap hook
4f99988 
Signed-off-by: Steve Winslow <swinslow@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2018
@chrisz100
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 25, 2018
chrisz100
chrisz100 approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@chrisz100 chrisz100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2018
@swinslow
Copy link
Contributor Author

/assign @justinsb

@justinsb
Copy link
Member

Thanks for figuring this out @swinslow

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, justinsb, swinslow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2018
@k8s-ci-robot k8s-ci-robot merged commit f72d570 into kubernetes:master Oct 27, 2018
@swinslow swinslow deleted the nvidia-license-stmt branch October 27, 2018 20:57
@swinslow swinslow mentioned this pull request Jan 23, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisz100 chrisz100 chrisz100 approved these changes

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

@chrisz100 chrisz100

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@swinslow @chrisz100 @justinsb @k8s-ci-robot