Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #6288: Recognize 2019 as a year #6364

Merged
merged 2 commits into from
Feb 28, 2019
Merged

Automated cherry pick of #6288: Recognize 2019 as a year #6364

merged 2 commits into from
Feb 28, 2019

Conversation

mikesplain
Copy link
Contributor

Cherry pick of #6288 on release-1.11.

#6288: Recognize 2019 as a year

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2019
@mikesplain
Copy link
Contributor Author

This should fix #6362 I believe?

@rdrgmnzs
Copy link
Contributor

/test pull-kops-e2e-kubernetes-aws-stable2
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2019
@mikesplain
Copy link
Contributor Author

/test pull-kops-e2e-kubernetes-aws-stable2

@zetaab
Copy link
Member

zetaab commented Feb 16, 2019

/test pull-kops-e2e-kubernetes-aws

@zetaab
Copy link
Member

zetaab commented Feb 16, 2019

/test pull-kops-e2e-kubernetes-aws-stable2

@k8s-ci-robot
Copy link
Contributor

@mikesplain: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kops-e2e-kubernetes-aws-stable2 3d54c0a link /test pull-kops-e2e-kubernetes-aws-stable2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikesplain
Copy link
Contributor Author

/retest

@mikesplain
Copy link
Contributor Author

/test pull-kops-e2e-kubernetes-aws-stable2

@justinsb
Copy link
Member

Going to merge this - I think that job is broken and has been removed, but this PR is "locked to it" because the tests are determined when the PR is created

@justinsb justinsb merged commit 0dfa51e into kubernetes:release-1.11 Feb 28, 2019
@mikesplain mikesplain deleted the automated-cherry-pick-of-#6288-origin-release-1.11 branch February 28, 2019 20:39
@ghost ghost mentioned this pull request Mar 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisz100 chrisz100 Awaiting requested review from chrisz100

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@rdrgmnzs rdrgmnzs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mikesplain @k8s-ci-robot @rdrgmnzs @zetaab @justinsb