Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize 2019 as a year #6288

Merged
merged 2 commits into from
Jan 3, 2019
Merged

Recognize 2019 as a year #6288

merged 2 commits into from
Jan 3, 2019

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Jan 2, 2019

Happy new year!

@justinsb
Recognize 2019 as a year
533a57a 
Happy new year!
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 2, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 2, 2019
@justinsb justinsb mentioned this pull request Jan 2, 2019
Merged
@rdrgmnzs
Copy link
Contributor

rdrgmnzs commented Jan 3, 2019

/lgtm
Happy new year!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2019
@justinsb
Copy link
Member Author

justinsb commented Jan 3, 2019

Looks like we have to regenerate the files as well, as it also picks up the different year. A little frustrating, but I think we can live with it...

@mikesplain
Copy link
Contributor

Thanks @justinsb!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justinsb,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 228bb2c into kubernetes:master Jan 3, 2019
@mikesplain mikesplain mentioned this pull request Jan 18, 2019
Merged
@ghost ghost mentioned this pull request Feb 21, 2019
Closed
justinsb added a commit that referenced this pull request Feb 28, 2019
@justinsb
Merge pull request #6364 from mikesplain/automated-cherry-pick-of-#62…
0dfa51e 
…88-origin-release-1.11

Automated cherry pick of #6288: Recognize 2019 as a year
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisz100 chrisz100 Awaiting requested review from chrisz100

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@rdrgmnzs rdrgmnzs

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justinsb @rdrgmnzs @mikesplain @k8s-ci-robot