-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.12.0-beta.1 bug - use dynamic s3 prefix in addAmazonVPCCNIPermissions func #6762
Conversation
Hi @bksteiny. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great find @bksteiny! Thanks so much!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bksteiny, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…62-origin-release-1.12 Automated cherry pick of #6762: use dynamic s3 prefix in addAmazonVPCCNIPermissions func
This PR is for #6754 (more info in that issue), which is currently a problem in the 1.12.0-beta.1 release. #6389 introduced a bug that only applies IAM policies correctly for AWS environments, and doesn't take into account AWS China and AWS Gov.
This change utilizes the
IAMPrefix
function to account for those environments.Before
After