Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AWS ap-east-1 region #6835

Merged
merged 2 commits into from
Apr 28, 2019
Merged

Conversation

wxdao
Copy link
Contributor

@wxdao wxdao commented Apr 26, 2019

This PR resolves #6832.

It has done 2 things:

  • Added ap-east-1[a-e] zones-to-cloud mappings in upup/pkg/fi/cloud.go.
  • Updated aws-go-sdk version to 1.19.18, the latest for now, so that aws client's DescribeRegions function can return regions with ap-east-1 correctly.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 26, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @wxdao. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 26, 2019
Copy link
Contributor

@rdrgmnzs rdrgmnzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 26, 2019
@mikesplain
Copy link
Contributor

Hey @wxdao! Thanks for your contribution, before we can test or merge this we need you to sign the CLA above. Luckily, once you do this once, you'll able to contribute to any of the kubernetes projects. Let us know if you run into any issues!

@mikesplain mikesplain added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Apr 26, 2019
@wxdao
Copy link
Contributor Author

wxdao commented Apr 26, 2019

Hey @wxdao! Thanks for your contribution, before we can test or merge this we need you to sign the CLA above. Luckily, once you do this once, you'll able to contribute to any of the kubernetes projects. Let us know if you run into any issues!

Hi mike. I'd like to get CLA ready as soon as possible. However I haven't received its register validation email for hours, not sure if I wrote down a wrong email address or their system glitched. Got no reply from their support yet, looking forward to resolve this soon.

@wxdao
Copy link
Contributor Author

wxdao commented Apr 27, 2019

OK I've signed it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 27, 2019
@mikesplain
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2019
@justinsb
Copy link
Member

This looks great, thanks you @wxdao

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, wxdao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2019
@justinsb
Copy link
Member

I'm guessing we're going to want this cherry-picked back to >= 1.12, possibly even to 1.11

@k8s-ci-robot k8s-ci-robot merged commit 85293df into kubernetes:master Apr 28, 2019
k8s-ci-robot added a commit that referenced this pull request May 10, 2019
k8s-ci-robot added a commit that referenced this pull request May 12, 2019
#6821-#6859-origin-release-1.13

Automated cherry pick of #6835: Add ap-east-1 zones infer #6821: update tolerations #6859: Protect against nil derefence
k8s-ci-robot added a commit that referenced this pull request May 12, 2019
#6821-#6859-origin-release-1.14

Automated cherry pick of #6835: Add ap-east-1 zones infer #6821: update tolerations #6859: Protect against nil derefence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working with the newly ap-east-1(Hong Kong) region
5 participants