Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix machine types with klog #6890

Merged
merged 1 commit into from
May 9, 2019
Merged

Fix machine types with klog #6890

merged 1 commit into from
May 9, 2019

Conversation

mikesplain
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2019
@justinsb
Copy link
Member

justinsb commented May 7, 2019

Thanks @mikesplain - I think we could also pass klog.InitFlags(nil) to register the flags, but logtostderr is now the default with klog

@justinsb
Copy link
Member

justinsb commented May 7, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justinsb,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikesplain
Copy link
Contributor Author

/retest

2 similar comments
@mikesplain
Copy link
Contributor Author

/retest

@mikesplain
Copy link
Contributor Author

/retest

@mikesplain
Copy link
Contributor Author

/milestone 1.13

@k8s-ci-robot k8s-ci-robot added this to the 1.13 milestone May 7, 2019
@rifelpet
Copy link
Member

rifelpet commented May 8, 2019

Looks like this e2e job needs to be killed and restarted

@rdrgmnzs
Copy link
Contributor

rdrgmnzs commented May 8, 2019 •
edited
Loading

/retest pull-kops-e2e-kubernetes-aws

going to ping the testing folks if this does not kick the job.

@mikesplain
Copy link
Contributor Author

This is likely kubernetes/test-infra#12527

@mikesplain
Copy link
Contributor Author

/retest

@rdrgmnzs
Copy link
Contributor

rdrgmnzs commented May 9, 2019

/refresh

@mikesplain mikesplain mentioned this pull request May 9, 2019
Merged
@rdrgmnzs
Copy link
Contributor

rdrgmnzs commented May 9, 2019

/test pull-kops-e2e-kubernetes-aws

1 similar comment
@rifelpet
Copy link
Member

rifelpet commented May 9, 2019

/test pull-kops-e2e-kubernetes-aws

@justinsb
Copy link
Member

justinsb commented May 9, 2019

/retest

CSI issues were #6899

@mikesplain
Copy link
Contributor Author

Oh great! Thanks @justinsb!

@k8s-ci-robot k8s-ci-robot merged commit a5a93c9 into kubernetes:master May 9, 2019
This was referenced May 10, 2019
Merged
Merged
@rifelpet rifelpet mentioned this pull request May 13, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request May 15, 2019
@k8s-ci-robot
Merge pull request #6933 from mikesplain/automated-cherry-pick-of-#6890-
4596d04 
#6893-#6898-origin-release-1.13

Automated cherry pick of #6890: Fix machine types with klog #6893: /etc/hosts (gossip): Stronger logic #6898: Add i3en
k8s-ci-robot added a commit that referenced this pull request May 15, 2019
@k8s-ci-robot
Merge pull request #6939 from mikesplain/automated-cherry-pick-of-#6890-
9a5d164 
#6893-#6898-origin-release-1.14

Automated cherry pick of #6890: Fix machine types with klog #6893: /etc/hosts (gossip): Stronger logic #6898: Add i3en
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mikesplain @justinsb @k8s-ci-robot @rifelpet @rdrgmnzs