Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #6945 #6951

Merged
merged 1 commit into from
May 14, 2019
Merged

Issue #6945 #6951

merged 1 commit into from
May 14, 2019

Conversation

pkutishch
Copy link
Contributor

Fixing LaunchTemplate removing

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @pkutishch. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 13, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2019
@pkutishch
Copy link
Contributor Author

pkutishch commented May 13, 2019

"I signed it"

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 13, 2019
@rifelpet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2019
@rifelpet
Copy link
Member

/test pull-kops-e2e-kubernetes-aws

@rifelpet
Copy link
Member

I think the test failures are the same intermittent csi issues that we were seeing last week.

/test pull-kops-e2e-kubernetes-aws

@granular-ryanbonham
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2019
@mikesplain
Copy link
Contributor

Testing this right now, but this looks pretty good

@mikesplain
Copy link
Contributor

Perfect, worked great. I'm going to merge this and open cherry-picks. Thanks @pkutishch!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, pkutishch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit 592062d into kubernetes:master May 14, 2019
k8s-ci-robot added a commit that referenced this pull request May 14, 2019
…51-origin-release-1.12

Automated cherry pick of #6951: LaunchTemplate - support for deletion of instance group which
k8s-ci-robot added a commit that referenced this pull request May 17, 2019
#7000-origin-release-1.14

Automated cherry pick of #6951: LaunchTemplate - support for deletion of instance group which #7000: Don't panic when deleting instancegroups
k8s-ci-robot added a commit that referenced this pull request May 17, 2019
#7000-origin-release-1.13

Automated cherry pick of #6951: LaunchTemplate - support for deletion of instance group which #7000: Don't panic when deleting instancegroups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants