Configuration to specify no SSH key #7096
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Hi @austinmoore-. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XXL
austinmoore-
changed the title
|
/assign @geojaz |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
@austinmoore- could you please look into the rebase issue? Thank you! |
k8s-ci-robot
removed
the
needs-rebase
|
Rebased on master |
|
/retest |
|
/retest |
austinmoore-
force-pushed
the
no-ssh-key
branch
2 times, most recently
from
5c21106
to
685e01f
Compare
protokube/pkg/gossip/mesh/mesh.pb.go
Outdated
| _ "github.com/gogo/protobuf/gogoproto" | ||
|
|
||
| errors "errors" | ||
|
|
There was a problem hiding this comment.
Any reason for the blank line between each import being added?
There was a problem hiding this comment.
No reason. Not sure why it got formatted this way but I'll clean it up
|
@rdrgmnzs How does it look? |
|
Really hoping to get this merged for the next release. Any chance this will make it? @rdrgmnzs @chrisz100 |
austinmoore-
force-pushed
the
no-ssh-key
branch
from
4253d3a
to
ccc6d62
Compare
|
Rebased onto master |
|
@rdrgmnzs @chrisz100 @granular-ryanbonham hoping to get this merged for the next release. Can you (or someone) take a look? |
|
@austinmoore- can you please rebase and fix the conflict? Once we get this up to date I'm hoping we can get it merged soon. thanks! |
austinmoore-
force-pushed
the
no-ssh-key
branch
from
ccc6d62
to
3ee3c53
Compare
|
@rifelpet Rebased (fixing tests) |
|
/test pull-kops-e2e-kubernetes-aws I think this might be a flake |
|
/test pull-kops-e2e-kubernetes-aws Got different test failures this time so trying again |
|
/test pull-kops-e2e-kubernetes-aws Jobs are finally passing, so lets try this again |
k8s-ci-robot
added
the
needs-rebase
|
@austinmoore- We really need this feature. |
|
@austinmoore apologies for the continued delay. Do you think you could rebase this one final time? I can work on getting this reviewed and merged ASAP. |
I think you meant to write to @austinmoore- (see "-" on the end of his user name). |
|
Oops, sorry about that :) |
austinmoore-
force-pushed
the
no-ssh-key
branch
from
329e117
to
9c4edd0
Compare
k8s-ci-robot
removed
the
needs-rebase
|
@austinmoore- looks great, thanks for sticking with it. If you can squash these commits then I think its ready to merge. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: austinmoore-, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Add tests for no ssh key functionality Add docs for setting no ssh key Disable sshKey rendering for cloudformation if nosshkey is set Fix broken test make goimports Fix Formatting fix Update kubernetes version for tests Update expected test output Fix imports in mesh.pb.go Run hack/update-expected.sh Change digital ocean logic to handle *string for SSHKeyName Fix expected output Missed a few
austinmoore-
force-pushed
the
no-ssh-key
branch
from
995a7f9
to
4a88f7b
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
…96-upstream-release-1.17 Automated cherry pick of #7096: Add ability to specify no ssh key by setting sshKeyName to
…96-upstream-release-1.16 Automated cherry pick of #7096: Add ability to specify no ssh key by setting sshKeyName to
Exposes configuration to allow a user to not specify an SSH key on an instance by setting
sshKeyName: "".Docs