Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require an SSH key to be set #2803

Closed
elliot opened this issue Jun 23, 2017 · 10 comments
Closed

Do not require an SSH key to be set #2803

elliot opened this issue Jun 23, 2017 · 10 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@elliot
Copy link

elliot commented Jun 23, 2017

It would be great to have a flag to disable setting an SSH key when creating AWS Launch Configurations.

Our use case is for a PCI-DSS environment. We are using pre-hardened AMI's that disabled creating default admin user accounts, but having a common SSH key associated with each instance raises questions for auditors as to who has access.

@jwickens
Copy link

jwickens commented Jul 5, 2017

this caught me out for a while while following the getting started guide for launching the basic cluster in aws.

@pieterlange
Copy link

pieterlange commented Jul 24, 2017

I believe its an AWS (API) requirement to assign a private key to each instance.

/edit: false. nevermind :)

@chrislovecnm
Copy link
Contributor

We allow re-using a key now. Please let me know if that helps

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 9, 2018
@chrislovecnm
Copy link
Contributor

/lifecycle frozen
/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Mar 10, 2018
@rickardrosen
Copy link

I've been working on a PR for this as we want to able to output TF code without an SSH key.

@elliot
Copy link
Author

elliot commented Jul 4, 2019

Possible fix in #7096

@rifelpet
Copy link
Member

rifelpet commented Aug 9, 2020

This has been implemented in Kops 1.18.0
/close

@k8s-ci-robot
Copy link
Contributor

@rifelpet: Closing this issue.

In response to this:

This has been implemented in Kops 1.18.0
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

8 participants