-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix template clusterName behavior #7319
Fix template clusterName behavior #7319
Conversation
This commit will allow you to define clusterName from the template's values file. Before that our clusterName value would be overriden by the cli flag ( whether defined or not ). Now we have an approach where if the value is defined, it will have priority over the cli flag. This commit will also align with the official documentation under https://github.com/kubernetes/kops/blob/master/docs/cluster_template.md
Hi @lcrisci. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This pr would address the following issue: #5454 |
/ok-to-test |
/retest |
/lgtm |
This looks good, thanks! I think technically we are changing behavior although previously we were just ignoring the value if it was set. Its probably worthy of a clear release note rather than being buried in the PR list. I can open that in a followup PR. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcrisci, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit will allow you to define clusterName from the template's values file.
Before that our clusterName value would be overriden by the cli flag ( whether defined or not ).
Now we have an approach where if the value is defined, it will have priority over the cli flag.
This commit will also align with the official documentation under https://github.com/kubernetes/kops/blob/master/docs/cluster_template.md