kops toolbox template: ignores config file for clusterName in templates

[ms4720]

------------- BUG REPORT TEMPLATE --------------------

1. What kops version are you running? The command kops version, will display
   this information.

Version 1.10.0-alpha.1

2. What Kubernetes version are you running? kubectl version will print the
   version if a cluster is running or provide the Kubernetes version specified as
   a kops flag.
   v1.10.5

3. What cloud provider are you using?
   AWS

4. What commands did you run? What is the simplest way to reproduce this issue?
   kops toolbox template --values=test.yml --template=template.yml --format-yaml

test.yml 
-----------
clusterName: bob

template.yml
---------
 kops.k8s.io/cluster: {{ .clusterName }}

5. What happened after the commands executed?

Using cluster from kubectl context: kube.XXXXX.com

kops.k8s.io/cluster: kube.XXXXXX.com

with no ~/.kube/config

kops toolbox template --values=config/test.yml --template=instance_groups/sample.yml --format-yaml
W0718 18:37:54.026010   44048 root.go:248] no context set in kubecfg
kops.k8s.io/cluster: null

I did not have a kube config file with multple clusters in it so I can not test for that behavior

6. What did you expect to happen?

kops.k8s.io/cluster: bob

Template generation should use the config file, pulling things out of kube config can lead to nasty suprises

7. Please provide your cluster manifest. Execute
   kops get --name my.example.com -o yaml to display your cluster manifest.
   You may want to remove your cluster name and other sensitive information.

N/A

8. Please run the commands with most verbose logging by adding the -v 10 flag.
   Paste the logs into this report, or in a gist and provide the gist link here.

N/A

9. Anything else do we need to know?

Workaround is just uses a different string for key

[tomdottom]

Possible duplicate of #5015

[ms4720]

similar, If I remember correctly it died with no ~/.kube/conf file. Related issue: are there any other magic variables in the code base? when making templates I really do not want it reading ~/.kube/conf for anything.

[ms4720]

I wonder if there are any other magic variables floating around.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[ms4720]

/remove-lifecycle rotten

[rifelpet]

It looks like this is the line in question:

kops/cmd/kops/toolbox_template.go

Line 114 in ed8e81c

context["clusterName"] = options.clusterName

If this was guarded with a conditional that checked whether it was already defined in the context, then you should be able to define it in a value and kops would no longer rely on the kubeconfig file.

[ms4720]

@rifelpet thanks for looking into it
I just might get a micro commit out of this

[grebois]

same issue with Version 1.11.0 (git-2c2042465)

[2tim]

Any update on this? It seems to render the template function unusable without a kubecfg. I was hoping to use this feature in a CI pipeline.

[ms4720]

@2tim I do not think you need a kubeconfig, you just need to have a config varable not called "clusterName" ( "myClusterName" works fine) that you call from the template to insert the cluster name in the yaml file. kops will still put out a message though, if I remember correctly.

[2tim]

Thanks for the tip. That was the first thing I tried due to the example. That not working, and the log message certainly don’t make me trust it but I will keep at it.

…

On Thu, Mar 21, 2019 at 8:58 PM Marc Spitzer ***@***.***> wrote: @2tim <https://github.com/2tim> I do not think you need a kubeconfig, you just need to have a config varable not called "clusterName" ( "myClusterName" works fine) that you call from the template to insert the cluster name in the yaml file. kops will still put out a message though, if I remember correctly. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5454 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE73vvVi2ribgTzaEwZaYArIbNweRQh6ks5vZDjNgaJpZM4VUXmo> .

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[lcrisci]

/remove-lifecycle rotten

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.