Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard External cloud controller manager with its feature flag #7770

Merged
merged 2 commits into from
Dec 26, 2019
Merged

Guard External cloud controller manager with its feature flag #7770

merged 2 commits into from
Dec 26, 2019

Conversation

mitch000001
Copy link
Contributor

Previously when setting the external cloud controller manager configuration the core components kubelet, apiserver and kubecontroller-manager were configured to use the external cloud controller manager. Without setting the feature flag EnableExternalCloudController this lead to a cluster in which the masters had the node taint node.cloudprovider.kubernetes.io/uninitialized which prevents essential pods, like dns-controller to not be scheduled and leaves a cluster where worker nodes can't connect to the api server because they cannot resolve its hostname.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 10, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @mitch000001. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2019
zetaab
zetaab approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2019
@mitch000001 mitch000001 force-pushed the external-cloud-controller-feature-flag branch from 744407c to 5593efe Compare October 10, 2019 19:37
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2019
@mitch000001
fix(external-ccm): prevent core components to be misconfigured
bfe9b21 
Previously when setting the external cloud controller manager
configuration the core components `kubelet`, `apiserver` and
`kubecontroller-manager` were configured to use the external cloud
controller manager. Without setting the feature flag
EnableExternalCloudController this lead to a cluster in which the
masters had the cloud controller taint
`node.cloudprovider.kubernetes.io/uninitialized` which prevents
essential pods, like dns-controller to not be scheduled and leaves a
cluster where worker nodes can't connect to the api server because they
cannot resolve its hostname.
@mitch000001
chore(external-ccm): warn user about missing feature flag
92ffa79
@mitch000001 mitch000001 force-pushed the external-cloud-controller-feature-flag branch from 5593efe to 92ffa79 Compare October 10, 2019 19:39
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2019
@mitch000001
Copy link
Contributor Author

@zetaab I fixed the bazel stuff. If it's green I am looking forward to your lgtm again :)

@zetaab
Copy link
Member

zetaab commented Oct 10, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2019
@mitch000001
Copy link
Contributor Author

@rifelpet Can you review that, please?

@rifelpet
Copy link
Member

rifelpet commented Nov 6, 2019

It looks good to me but I don’t have permission to approve the PR in order to get it merged, you’ll need one of the “approvers” in the OWNERS file to do that

@mitch000001
Copy link
Contributor Author

@mikesplain Can you give it a look and if you like what you see approve it?

@johngmyers
Copy link
Member

/test pull-kops-verify-staticcheck

@rifelpet
Copy link
Member

now that i'm an approver...

/approve
thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mitch000001, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit dd608e8 into kubernetes:master Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab zetaab approved these changes

@rifelpet rifelpet Awaiting requested review from rifelpet

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mitch000001 @k8s-ci-robot @zetaab @rifelpet @johngmyers