Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard External cloud controller manager with its feature flag #7770

Merged
merged 2 commits into from
Dec 26, 2019
Merged

Guard External cloud controller manager with its feature flag #7770

merged 2 commits into from
Dec 26, 2019

Commits on Oct 10, 2019

  1. fix(external-ccm): prevent core components to be misconfigured 

    Previously when setting the external cloud controller manager
configuration the core components `kubelet`, `apiserver` and
`kubecontroller-manager` were configured to use the external cloud
controller manager. Without setting the feature flag
EnableExternalCloudController this lead to a cluster in which the
masters had the cloud controller taint
`node.cloudprovider.kubernetes.io/uninitialized` which prevents
essential pods, like dns-controller to not be scheduled and leaves a
cluster where worker nodes can't connect to the api server because they
cannot resolve its hostname.
    @mitch000001
    mitch000001 committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    bfe9b21 View commit details
    Browse the repository at this point in the history

  2. chore(external-ccm): warn user about missing feature flag

    @mitch000001
    mitch000001 committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    92ffa79 View commit details
    Browse the repository at this point in the history