-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused functions and simplify return str #7792
remove unused functions and simplify return str #7792
Conversation
Hi @tanjunchen. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @gambol99 |
/lgtm |
@mikesplain @justinsb Can you help me review this pr? Thanks |
/test pull-kops-bazel-build |
/test pull-kops-e2e-kubernetes-aws |
Wow - thanks for finding all these unused functions! We should delete them if they are unused! I know some of them may be related to e.g. the memberlist work, so I'm first going to make sure that there's not another PR that references these functions. But this LGTM! Or maybe we merge this as one of the first PRs after we cut the 1.16 branch, just in case... Because of go interface rules it can sometimes be tricky to see if a function is indeed unused! |
now that we have plenty of new release branches, this seems safe for master. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet, tanjunchen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@justinsb @zetaab
can you help me review these changes?Thanks!
Maybe some functions are important,we need to talk about them remove or not?
#7800