Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused functions and simplify return str #7792

Merged
merged 2 commits into from
Dec 10, 2019
Merged

remove unused functions and simplify return str #7792

merged 2 commits into from
Dec 10, 2019

Conversation

tanjunchen
Copy link
Member

@tanjunchen tanjunchen commented Oct 15, 2019

@justinsb @zetaab
can you help me review these changes?Thanks!
Maybe some functions are important,we need to talk about them remove or not?
#7800

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 15, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @tanjunchen. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 15, 2019
@tanjunchen
Copy link
Member Author

/assign @gambol99

@hwdef
Copy link
Member

hwdef commented Oct 17, 2019

/lgtm
/ok-to-test
Thanks for your contribution.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2019
@tanjunchen
Copy link
Member Author

@mikesplain @justinsb Can you help me review this pr? Thanks

@tanjunchen
Copy link
Member Author

/test pull-kops-bazel-build

@tanjunchen
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws

@justinsb
Copy link
Member

Wow - thanks for finding all these unused functions!

We should delete them if they are unused! I know some of them may be related to e.g. the memberlist work, so I'm first going to make sure that there's not another PR that references these functions. But this LGTM!

Or maybe we merge this as one of the first PRs after we cut the 1.16 branch, just in case... Because of go interface rules it can sometimes be tricky to see if a function is indeed unused!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2019
@rifelpet
Copy link
Member

now that we have plenty of new release branches, this seems safe for master.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2019
@tanjunchen
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 11cec04 into kubernetes:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants