[Help] Clean up static check failures

[tanjunchen]

1. Describe IN DETAIL the feature/behavior/change you would like to see.
There are many packages that can't pass the static check and we need to clean them up even though hack/verify-staticcheck.sh exsits in the kops.
Step 1: Remove some packages(related packages) from the list in https://github.com/kubernetes/kops/blob/master/hack/.staticcheck_failures ,
Step 2: Run hack/verify-staticcheck.sh and look at outputs from console
Step 3: Fix them to ensure that hack/verify-staticcheck.sh runs cleanly
Step 4: Run hack/verify-bazel.sh and hack/verify-gofmt.sh to make sure that you fix any problems with bazel or gofmt.
Step 5: How to make prs?

• For existing contributor,make sure there lists are up to date.
• advice title begins with staticchek:
• Don't use Fixes: [Help] Clean up static check failures  #7800 which will shut down the issue,just use Ref:[Help] Clean up static check failures  #7800
• example for description

https://github.com/kubernetes/kops/pull/8203#issue-356845565

Attention: if you have any questions
read this https://github.com/kubernetes/kops/blob/master/docs/development/vendoring.md

[tanjunchen]

/help

[k8s-ci-robot]

@tanjunchen:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tanjunchen]

/priority important-longterm

[k8s-ci-robot]

@tanjunchen: The label(s) priority/ cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

/priority important-longterm
/sig testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rendhalver]

I am interested in getting started helping out with kops.
How much of this is left to do?

[rifelpet]

Thanks for volunteering! Most of the staticcheck issues have been addressed but you can certainly check the remaining issues in hack/.staticcheck_failures for the remaining ones, besides the PR listed above that is currently open.

I'm adding an additional check in #8328 similar to staticcheck but for shell scripts: shellcheck. Feel free to check it out and start fixing some of the reported issues.

[rendhalver]

Awesome. Thanks for the pointer @rifelpet!
I will see what I can work out.

[rendhalver]

Hrm. There's only one entry in hack/.staticcheck_failures and it looks like #7839 fixes at least some of those.
I will see I can what I can do to help out with the shellcheck fixes. :)

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[rifelpet]

all the staticcheck failures have been fixed. good job everyone
/close

[k8s-ci-robot]

@rifelpet: Closing this issue.

In response to this:

all the staticcheck failures have been fixed. good job everyone
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.