-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DrainAndValidateRollingUpdate feature flag #7909
Remove DrainAndValidateRollingUpdate feature flag #7909
Conversation
Hi @johngmyers. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
The feature flag was switched to enable-by-default 2 years ago: back in Kops 1.8, so I think its safe to remove it now. /lgtm |
f08d865
to
4eccd3d
Compare
/test pull-kops-verify-staticcheck |
Thanks for driving this @johngmyers - great to see the rolling update code getting improved! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's excessive having this and
CloudOnly
andFailOnValidate
andFailOnDrainError
.