Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix some broken development links #8075

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

gjtempleton
Copy link
Member

@gjtempleton gjtempleton commented Dec 10, 2019

Couple of minor link fixes to development related docs/images

Also cleans up the lists under issues and pull requests headings in welcome/contributing.md and lists in welcome/office_hours.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2019
@gjtempleton gjtempleton force-pushed the Fix-Docs-Links branch 2 times, most recently from a8e5148 to 8989e34 Compare December 10, 2019 09:53
@gjtempleton gjtempleton changed the title Fix some broken development docs links Docs: Fix some broken development docs links Dec 10, 2019
@gjtempleton gjtempleton changed the title Docs: Fix some broken development docs links Fix some broken development links Dec 10, 2019
@gjtempleton gjtempleton changed the title Fix some broken development links Docs: Fix some broken development links Dec 10, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2019
@joshbranham
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2019
@rifelpet
Copy link
Member

Awesome! the preview site really makes reviewing these changes easier.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit dec416f into kubernetes:master Dec 10, 2019
@mikesplain
Copy link
Contributor

Glad to hear it! Thanks @gjtempleton for catching these!

@gjtempleton gjtempleton deleted the Fix-Docs-Links branch December 10, 2019 17:00
@gjtempleton
Copy link
Member Author

Yep, definitely makes things far simpler for these PRs, thanks again for the hard work in getting it up and running @mikesplain !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants