Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/pkg/ upup/tools/ : simplify code and remove unused code #8121

Merged
merged 1 commit into from
Dec 17, 2019
Merged

util/pkg/ upup/tools/ : simplify code and remove unused code #8121

merged 1 commit into from
Dec 17, 2019

Conversation

tanjunchen
Copy link
Member

@tanjunchen tanjunchen commented Dec 16, 2019 •
edited
Loading

ref:#7800

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 16, 2019
@tanjunchen
Copy link
Member Author

/test pull-kops-verify-govet

@tanjunchen tanjunchen changed the title util/pkg/ upup/tools/ simplify code and remove unused code util/pkg/ upup/tools/ : simplify code and remove unused code Dec 16, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 17, 2019
@tanjunchen
Copy link
Member Author

/retest

1 similar comment
@tanjunchen
Copy link
Member Author

/retest

@tanjunchen
Copy link
Member Author

/cc @rifelpet

@justinsb
Copy link
Member

It looks like the 10 millisecond timeout for the validate test might be a little tight - triggered a Travis retest on that.

Thanks you for this @tanjunchen - really great to see more static analysis coverage!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2019
@rifelpet
Copy link
Member

/test pull-kops-e2e-kubernetes-aws

@k8s-ci-robot k8s-ci-robot merged commit 252a733 into kubernetes:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tanjunchen @justinsb @k8s-ci-robot @rifelpet