Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsprovider/pkg/dnsprovider - fix static check #8149

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

hakman
Copy link
Member

@hakman hakman commented Dec 18, 2019

Ref: #7800

Errors from staticcheck:

dnsprovider/pkg/dnsprovider/providers/aws/route53/route53_test.go:131:6: func getInvalidRrs is unused (U1000)
dnsprovider/pkg/dnsprovider/providers/coredns/coredns_test.go:111:6: func listRrsOrFail is unused (U1000)
dnsprovider/pkg/dnsprovider/providers/google/clouddns/clouddns_test.go:109:6: func getInvalidRrs is unused (U1000)
dnsprovider/pkg/dnsprovider/providers/google/clouddns/internal/clouddns.go:28:18: field impl is unused (U1000)
dnsprovider/pkg/dnsprovider/providers/google/clouddns/internal/clouddns.go:30:26: field impl is unused (U1000)
dnsprovider/pkg/dnsprovider/providers/google/clouddns/internal/clouddns.go:34:16: field impl is unused (U1000)
dnsprovider/pkg/dnsprovider/providers/google/clouddns/internal/stubs/clouddns.go:29:26: field impl is unused (U1000)
dnsprovider/pkg/dnsprovider/providers/google/clouddns/internal/stubs/clouddns.go:30:26: field impl is unused (U1000)
dnsprovider/pkg/dnsprovider/providers/google/clouddns/internal/stubs/clouddns.go:31:26: field impl is unused (U1000)
dnsprovider/pkg/dnsprovider/providers/google/clouddns/internal/stubs/clouddns.go:32:26: field impl is unused (U1000)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 18, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @hakman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2019
@hakman
Copy link
Member Author

hakman commented Dec 18, 2019

/cc @tanjunchen

@tanjunchen
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 18, 2019
@hakman
Copy link
Member Author

hakman commented Dec 18, 2019

/assign @geojaz

@geojaz
Copy link
Member

geojaz commented Dec 19, 2019

this looks great to me, but i'm not sure that i have all the context... afaict, this essentially looks like a removal of dead code. @justinsb : any concerns here?

@geojaz
Copy link
Member

geojaz commented Dec 19, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 19, 2019
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 23, 2019
Copy link
Member

@geojaz geojaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 24, 2019
@tanjunchen
Copy link
Member

/lgtm

@rifelpet
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5cb2d36 into kubernetes:master Dec 24, 2019
@hakman hakman deleted the staticcheck-dnsprovider branch December 27, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants