Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verify-staticcheck prow job #8182

Merged
merged 2 commits into from
Dec 23, 2019
Merged

Fix verify-staticcheck prow job #8182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef8f07c
Fix verify-staticcheck prow job
rifelpet Dec 22, 2019
e7e9e62
Remove packages from staticcheck failure list that are no longer failing
rifelpet Dec 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ verify-bazel:
hack/verify-bazel.sh

.PHONY: verify-staticcheck
verify-staticcheck:
verify-staticcheck: ${BINDATA_TARGETS}
hack/verify-staticcheck.sh

# ci target is for developers, it aims to cover all the CI jobs
Expand Down
2 changes: 0 additions & 2 deletions hack/.staticcheck_failures
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
cloudmock/aws/mockelbv2
cmd/kops
dnsprovider/pkg/dnsprovider
dnsprovider/pkg/dnsprovider/providers/aws/route53
dnsprovider/pkg/dnsprovider/providers/coredns
dnsprovider/pkg/dnsprovider/providers/google/clouddns
dnsprovider/pkg/dnsprovider/providers/google/clouddns/internal
dnsprovider/pkg/dnsprovider/providers/google/clouddns/internal/stubs
dnsprovider/pkg/dnsprovider/providers/openstack/designate
node-authorizer/pkg/authorizers/aws
node-authorizer/pkg/server
pkg/instancegroups
Expand Down
2 changes: 2 additions & 0 deletions hack/verify-staticcheck.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ go install k8s.io/kops/vendor/honnef.co/go/tools/cmd/staticcheck

cd "${KUBE_ROOT}"

make upup/models/bindata.go

# Check that the file is in alphabetical order
failure_file="${KUBE_ROOT}/hack/.staticcheck_failures"
if ! diff -u "${failure_file}" <(LC_ALL=C sort "${failure_file}"); then
Expand Down