Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing priorityClassName for critical pods #8200

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Add missing priorityClassName for critical pods #8200

merged 3 commits into from
Jan 29, 2020

Conversation

johngmyers
Copy link
Member

@johngmyers johngmyers commented Dec 25, 2019 •
edited
Loading

/kind bug

Several pod manifests with the scheduler.alpha.kubernetes.io/critical-pod annotation (for which support was removed in Kubernetes 1.16) were missing a corresponding priorityClassName.

Fixes #7605

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 25, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @johngmyers. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 25, 2019
@rifelpet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 25, 2019
@johngmyers
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws

2 similar comments
@johngmyers
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws

@johngmyers
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws

@johngmyers
Copy link
Member Author

Fixes #7605

@johngmyers johngmyers mentioned this pull request Jan 29, 2020
Merged
@justinsb
Copy link
Member

I believe we've now unblocked this, and we would like to merge this and cherry-pick back to >= 1.16 (?)

Thanks for driving this @johngmyers - though I think it needs a rebase (hopefully just one more!)

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2020
@johngmyers
Merge branch 'master' into critical-pod
9f3e31c 
Conflicts:
	upup/pkg/fi/cloudup/bootstrapchannelbuilder.go
	upup/pkg/fi/cloudup/tests/bootstrapchannelbuilder/amazonvpc/manifest.yaml
	upup/pkg/fi/cloudup/tests/bootstrapchannelbuilder/cilium/manifest.yaml
	upup/pkg/fi/cloudup/tests/bootstrapchannelbuilder/simple/manifest.yaml
	upup/pkg/fi/cloudup/tests/bootstrapchannelbuilder/weave/manifest.yaml
@johngmyers
update-expected.sh
329f56c
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 29, 2020
@rifelpet
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit 02def1c into kubernetes:master Jan 29, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 29, 2020
k8s-ci-robot added a commit that referenced this pull request Jan 29, 2020
@k8s-ci-robot
Merge pull request #8439 from johngmyers/cherrypick-8200-1.17
cc63960 
Cherry pick of #8200: Add missing priorityClassName for critical pods
k8s-ci-robot added a commit that referenced this pull request Jan 29, 2020
@k8s-ci-robot
Merge pull request #8440 from johngmyers/cherrypick-8200-1.16
a2ee93e 
Cherry pick of #8200: Add missing priorityClassName for critical pods
@johngmyers johngmyers deleted the critical-pod branch January 29, 2020 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

Critical pod annotation - used by kube-proxy - is now deprecated
4 participants
@johngmyers @k8s-ci-robot @rifelpet @justinsb