Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodeup/pkg/ pkg/ staticcheck: Fix ST1005 #8234

Merged
merged 1 commit into from
Dec 31, 2019
Merged

nodeup/pkg/ pkg/ staticcheck: Fix ST1005 #8234

merged 1 commit into from
Dec 31, 2019

Conversation

tanjunchen
Copy link
Member

ref:#7800

nodeup/pkg/model/context.go:570:24: error strings should not be capitalized (ST1005)
nodeup/pkg/model/context.go:574:24: error strings should not be capitalized (ST1005)
nodeup/pkg/model/file_assets.go:86:22: error strings should not be capitalized (ST1005)
nodeup/pkg/model/kube_apiserver.go:278:19: error strings should not be capitalized (ST1005)
nodeup/pkg/model/kube_proxy.go:132:25: error strings should not be capitalized (ST1005)
nodeup/pkg/model/kube_proxy.go:140:26: error strings should not be capitalized (ST1005)
nodeup/pkg/model/kube_proxy.go:148:26: error strings should not be capitalized (ST1005)
nodeup/pkg/model/kube_proxy.go:156:26: error strings should not be capitalized (ST1005)
nodeup/pkg/model/volumes.go:48:21: error strings should not be capitalized (ST1005)
nodeup/pkg/model/volumes.go:58:21: error strings should not be capitalized (ST1005)
pkg/model/components/context.go:130:24: error strings should not be capitalized (ST1005)
pkg/nodeidentity/do/identify.go:172:23: error strings should not be capitalized (ST1005)
pkg/resources/aws/aws.go:270:25: error strings should not be capitalized (ST1005)
pkg/resources/aws/aws.go:365:25: error strings should not be capitalized (ST1005)
pkg/testutils/modelharness.go:74:26: error strings should not be capitalized (ST1005)
pkg/util/subnet/subnet.go:64:26: error strings should not be capitalized (ST1005)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 31, 2019
@tanjunchen
Copy link
Member Author

/cc @rifelpet
@hakman
for review

@hakman
Copy link
Member

hakman commented Dec 31, 2019

Maybe would be easier to fix each ST category in 1 PR now. Even if there are many such cases, the changes are pretty simple to review.

Should be pretty easy to comment each category in the script and fix them at same time:
https://github.com/kubernetes/kops/blob/master/hack/verify-staticcheck.sh#L51-L56

What do you think @tanjunchen ?

@tanjunchen
Copy link
Member Author

Maybe would be easier to fix each ST category in 1 PR now. Even if there are many such cases, the changes are pretty simple to review.

Should be pretty easy to comment each category in the script and fix them at same time:
https://github.com/kubernetes/kops/blob/master/hack/verify-staticcheck.sh#L51-L56

What do you think @tanjunchen ?

Agree , after merge there prs , i will do it . hehe

@hakman
Copy link
Member

hakman commented Dec 31, 2019

Agree , after merge there prs , i will do it . hehe

I think you have a few PRs for ST1005 already. You could just rename this to "staticcheck: Fix ST1005" and start with them here.

@tanjunchen
Copy link
Member Author

staticcheck: Fix ST1005

done

@tanjunchen tanjunchen changed the title nodeup/pkg/ pkg/ staticcheck nodeup/pkg/ pkg/ staticcheck: Fix ST1005 Dec 31, 2019
@rifelpet
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit befa1d7 into kubernetes:master Dec 31, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants