-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodeup/pkg/ pkg/ staticcheck: Fix ST1005 #8234
Conversation
Maybe would be easier to fix each ST category in 1 PR now. Even if there are many such cases, the changes are pretty simple to review. Should be pretty easy to comment each category in the script and fix them at same time: What do you think @tanjunchen ? |
Agree , after merge there prs , i will do it . hehe |
I think you have a few PRs for ST1005 already. You could just rename this to "staticcheck: Fix ST1005" and start with them here. |
done |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet, tanjunchen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ref:#7800
nodeup/pkg/model/context.go:570:24: error strings should not be capitalized (ST1005)
nodeup/pkg/model/context.go:574:24: error strings should not be capitalized (ST1005)
nodeup/pkg/model/file_assets.go:86:22: error strings should not be capitalized (ST1005)
nodeup/pkg/model/kube_apiserver.go:278:19: error strings should not be capitalized (ST1005)
nodeup/pkg/model/kube_proxy.go:132:25: error strings should not be capitalized (ST1005)
nodeup/pkg/model/kube_proxy.go:140:26: error strings should not be capitalized (ST1005)
nodeup/pkg/model/kube_proxy.go:148:26: error strings should not be capitalized (ST1005)
nodeup/pkg/model/kube_proxy.go:156:26: error strings should not be capitalized (ST1005)
nodeup/pkg/model/volumes.go:48:21: error strings should not be capitalized (ST1005)
nodeup/pkg/model/volumes.go:58:21: error strings should not be capitalized (ST1005)
pkg/model/components/context.go:130:24: error strings should not be capitalized (ST1005)
pkg/nodeidentity/do/identify.go:172:23: error strings should not be capitalized (ST1005)
pkg/resources/aws/aws.go:270:25: error strings should not be capitalized (ST1005)
pkg/resources/aws/aws.go:365:25: error strings should not be capitalized (ST1005)
pkg/testutils/modelharness.go:74:26: error strings should not be capitalized (ST1005)
pkg/util/subnet/subnet.go:64:26: error strings should not be capitalized (ST1005)