Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upup/pkg/fi/cloudup/ staticcheck: Fix ST1005 #8236

Merged
merged 1 commit into from
Dec 31, 2019
Merged

upup/pkg/fi/cloudup/ staticcheck: Fix ST1005 #8236

merged 1 commit into from
Dec 31, 2019

Conversation

tanjunchen
Copy link
Member

ref:#7800
TLTR

/cc @rifelpet
/cc @justinsb
@hakman

upup/pkg/fi/cloudup/openstack/server_group.go:121:26: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstack/utils.go:59:24: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstack/utils.go:64:24: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstack/utils.go:96:24: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstack/utils.go:112:24: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstack/utils.go:115:23: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/floatingip.go:56:28: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/floatingip.go:107:25: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/floatingip.go:111:26: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/floatingip.go:159:26: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/floatingip.go:165:26: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/floatingip.go:178:26: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/floatingip.go:187:28: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/floatingip.go:236:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/floatingip.go:248:22: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/floatingip.go:255:22: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/floatingip.go:263:22: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/floatingip.go:270:22: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/floatingip.go:284:22: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/floatingip.go:290:22: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/floatingip.go:296:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/floatingip.go:296:21: error strings should not end with punctuation or a newline (ST1005)
upup/pkg/fi/cloudup/openstacktasks/instance.go:114:25: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/instance.go:196:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/instance.go:217:25: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/instance.go:235:26: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/lb.go:155:25: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/lb.go:159:25: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/lb.go:165:25: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/lb.go:199:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/lb.go:202:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/lb.go:222:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/lb.go:229:20: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/lb.go:240:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/lblistener.go:95:25: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/lblistener.go:101:25: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/lbpool.go:56:25: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/lbpool.go:56:25: error strings should not end with punctuation or a newline (ST1005)
upup/pkg/fi/cloudup/openstacktasks/lbpool.go:95:25: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/lbpool.go:101:25: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/network.go:79:25: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/network.go:123:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/network.go:128:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/network.go:137:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/poolassociation.go:144:22: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/poolassociation.go:150:22: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/poolassociation.go:160:22: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/port.go:166:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/port.go:171:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/port.go:177:22: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/port.go:186:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/port.go:208:26: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/router.go:98:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/router.go:107:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/router.go:119:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/routerinterface.go:131:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/servergroup.go:57:25: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/servergroup.go:61:25: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/servergroup.go:67:27: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/servergroup.go:148:23: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/sshkey.go:129:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/subnet.go:167:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/subnet.go:172:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/subnet.go:181:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/openstacktasks/volume.go:126:21: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/populate_cluster_spec.go:333:20: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/populate_instancegroup_spec.go:125:27: error strings should not be capitalized (ST1005)
upup/pkg/fi/cloudup/populate_instancegroup_spec.go:134:26: error strings should not be capitalized (ST1005)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 31, 2019
@tanjunchen tanjunchen changed the title upup/pkg/fi/cloudup/ staticcheck upup/pkg/fi/cloudup/ staticcheck: Fix ST1005 Dec 31, 2019
@tanjunchen
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws

1 similar comment
@rifelpet
Copy link
Member

/test pull-kops-e2e-kubernetes-aws

@rifelpet
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit c323819 into kubernetes:master Dec 31, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tanjunchen @rifelpet @k8s-ci-robot