Automated cherry pick of #8373: Prefix git tags with v
#8421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go modules require the v prefix [0], and k/k also tags with the v prefix [1] We have some inconsistent tags already, for 1.11.0 we have tags of both `1.11.0` and `v1.11.0` which is the most recent tag with the prefix. This is also why 1.11.0 is the default version imported by `go get`: ``` go get -v k8s.io/kops go: downloading k8s.io/kops v1.11.0 ``` and the latest version in `go list`: ``` go list -m -versions k8s.io/kops k8s.io/kops v1.4.0-alpha.1 v1.4.0 v1.4.1 v1.4.2 v1.4.3 v1.4.4 v1.10.0 v1.11.0 ``` I'm proposing we switch to only tagging with the v prefix. I'm only updating the actual git tag and not the entire version string used throughout kops due to its larger impact: * Output by `kops version` * Public URLs for kops assets * Protokube tag I'm hoping this is the least invasive way we can make this change. If we think advanced notice is required, we could tag with both formats for a number of releases before tagging only with the v prefix. [0] https://github.com/golang/go/wiki/Modules#modules [1] https://github.com/kubernetes/kubernetes/releases/tag/v1.17.0
k8s-ci-robot
added
cncf-cla: yes
|
/retest |
1 similar comment
|
/retest |
|
/test pull-kops-e2e-kubernetes-aws-1-16 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
johngmyers
deleted the
automated-cherry-pick-of-#8373-upstream-release-1.16
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #8373 on release-1.16.
#8373: Prefix git tags with
vFor details on the cherry pick process, see the cherry pick requests page.