Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cluster name as default subnet tag for Lyft CNI #8571

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Use cluster name as default subnet tag for Lyft CNI #8571

merged 1 commit into from
Feb 17, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Feb 16, 2020 •
edited
Loading

The Lyft CNI uses tags to determine which subnets to use when allocating new network adapters.
Current default is not matching anything, so the cluster is broken on startup. Using the cluster name for to determine the cluster subnets seems a better solution.

The the conflist.template was misaligned so I reformatted it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 16, 2020
@hakman
Copy link
Member Author

hakman commented Feb 16, 2020

/assign @rifelpet

@hakman hakman mentioned this pull request Feb 16, 2020
Merged
@maruina
Copy link
Contributor

maruina commented Feb 16, 2020

Looks good

@rifelpet
Copy link
Member

Hm i think technically this would be considered a breaking change. If someone's subnets were only tagged with type: pod and then upgraded kops, their cluster would use IPs in different subnets after a rolling-update. I'm wondering how we could best gate this change or otherwise have users opt in to it. Realistically I don't know how if people would really depend on type: pod as a tag without also specifying additional tags, but we should at the very least call it out in release notes.

Thoughts?

@hakman
Copy link
Member Author

hakman commented Feb 17, 2020

@rifelpet I would say Release Notes / Breaking Changes mention should be a good idea. Kops tries to make these network plugins work out of the box as much as possible, to make it easier to get started. I also don't think the type: pod is something that anyone would like to use in prod, I will additionally gate it to 1.18, just to be on the safe side.

rifelpet
rifelpet reviewed Feb 17, 2020
View reviewed changes
docs/releases/1.18-NOTES.md Outdated
@@ -6,6 +6,8 @@

* Terraform users on AWS may need to rename some resources in their state file in order to prepare for Terraform 0.12 support. See Required Actions below.

* Lyft CNI plugin default subnet tags changed from from `Type: pod` to `KubernetesCluster: myclustername.mydns.io`.
Copy link
Member

@rifelpet rifelpet Feb 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should describe the action a user would want to take if they're affected by this.

Subnets intended for pod IP use will need to be tagged with this new tag, and additional tag filters may need to be added to the cluster spec in order to achieve the desired set of subnets.

or something along those lines.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think should be ok now.

@hakman hakman requested a review from rifelpet February 17, 2020 15:44
@rifelpet
Copy link
Member

One step closer to e2e for lyft cni!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2020
@hakman
Copy link
Member Author

hakman commented Feb 17, 2020

One step closer to e2e for lyft cni!

🤞

@k8s-ci-robot k8s-ci-robot merged commit 10138d8 into kubernetes:master Feb 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 17, 2020
@hakman hakman deleted the lyft-subnet-tags branch February 21, 2020 03:30
@hakman hakman mentioned this pull request May 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hakman @maruina @rifelpet @k8s-ci-robot