Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport from master: Set the default instance type to t3.medium for AWS #8652

Closed
wants to merge 1 commit into from
Closed

Backport from master: Set the default instance type to t3.medium for AWS #8652

wants to merge 1 commit into from

Conversation

jeffb4
Copy link
Contributor

@jeffb4 jeffb4 commented Feb 28, 2020

This changeset backports 7a42cf4 from master into the 1.16 release branch.

Reasons:

  • this change is very low impact
  • 1.17 is still in beta
  • this change didn't make it into 1.17 anyway
  • it would make my govcloud deployments immensely easier, for reasons

I don't know the kops policy on backporting, I'll understand if it doesn't meet criteria to go into 1.16.1 .

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Feb 28, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 28, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @jeffb4!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @jeffb4. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jeffb4
To complete the pull request process, please assign justinsb
You can assign the PR to them by writing /assign @justinsb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jeffb4
Copy link
Contributor Author

jeffb4 commented Feb 28, 2020

/assign @justinsb

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 28, 2020
@hakman
Copy link
Member

hakman commented Feb 28, 2020

@jeffb4 unfortunately this is a pretty big change to cherry-pick to a released version.
1.17 is still open though. Would it help to cherry-pick it to 1.17, considering that it should be released in about 1 month or so?

@jeffb4
Copy link
Contributor Author

jeffb4 commented Feb 28, 2020

Certainly. Should I open such a PR or would you prefer to?

@hakman
Copy link
Member

hakman commented Feb 29, 2020

Don't worry. The release notes part is a bit more complicated. Thanks for making the effort to create this PR though.
Closing this in favour of #8656.
/close

@k8s-ci-robot
Copy link
Contributor

@hakman: Closed this PR.

In response to this:

Don't worry. The release notes part is a bit more complicated. Thanks for making the effort to create this PR though.
Closing this in favour of #8656.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeffb4 jeffb4 deleted the backport-instancegroup-defaults-to-1.16 branch March 3, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants