Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #8282: Set the default instance type to t3.medium for AWS #8656

Merged
merged 1 commit into from
Feb 29, 2020
Merged

Automated cherry pick of #8282: Set the default instance type to t3.medium for AWS #8656

merged 1 commit into from
Feb 29, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Feb 29, 2020

Cherry pick of #8282 on release-1.17.

#8282: Set the default instance type to t3.medium for AWS

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Feb 29, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 29, 2020
@hakman hakman mentioned this pull request Feb 29, 2020
Closed
@hakman
Copy link
Member Author

hakman commented Feb 29, 2020

/assign @rifelpet

@mikesplain
Copy link
Contributor

Thanks @hakman!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit c43dd85 into kubernetes:release-1.17 Feb 29, 2020
@hakman hakman mentioned this pull request Mar 1, 2020
Merged
@jeffb4
Copy link
Contributor

jeffb4 commented Mar 3, 2020

This cherry-pick didn't seem to update release notes. For my info when opening PRs in the future, is there guidance about when such are necessary? (@hakman )

@hakman
Copy link
Member Author

hakman commented Mar 3, 2020

@jeffb4 the release notes changes have to be done on master for now. This is the PR that took care of this change: #8658 .

@hakman hakman deleted the automated-cherry-pick-of-#8282-upstream-release-1.17 branch March 3, 2020 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gambol99 gambol99 Awaiting requested review from gambol99

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@mikesplain mikesplain

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hakman @mikesplain @k8s-ci-robot @jeffb4 @rifelpet