Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add root volume tags for CF and TF targets #8693

Merged
merged 3 commits into from Mar 16, 2020
Merged

Add root volume tags for CF and TF targets #8693

merged 3 commits into from Mar 16, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Mar 8, 2020 •
edited

Adding root volume tags has been requested for a long time #3358 and was implemented in #8462 and #8466, but only for the direct target.

This PR adds root volume tags for terraform and cloudformation targets when using launch templates or mixed instances policies.

Notes:

  • launch templates were not working at all
  • an autoscaling group should use only one of launch configuration, launch template or mixed instances policy
  • security groups should be specified for each network interface, instead of globally (global was meant for EC2 Classic and Default VPC)
  • to enable the launch templates feature, the EnableLaunchTemplates feature flag must be specified

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 8, 2020
@hakman hakman force-pushed the launch-template-tags-cf-tf branch from faf8474 to 725dd1a Compare March 8, 2020 05:24
@hakman
Copy link
Member Author

hakman commented Mar 8, 2020

/cc @rifelpet @KashifSaadat @granular-ryanbonham

johngmyers
johngmyers requested changes Mar 8, 2020
View reviewed changes
Copy link
Member

@johngmyers johngmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know Terraform/Cloudformation, so won't be able to lgtm.

upup/pkg/fi/cloudup/awstasks/autoscalinggroup.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/awstasks/autoscalinggroup.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/awstasks/autoscalinggroup.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/awstasks/autoscalinggroup.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/awstasks/autoscalinggroup.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/awstasks/launchtemplate_target_cloudformation.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/awstasks/launchtemplate_target_cloudformation.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/awstasks/launchtemplate_target_terraform.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/awstasks/launchtemplate_target_terraform.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/awstasks/launchtemplate_target_terraform.go Outdated Show resolved Hide resolved
@hakman hakman requested a review from johngmyers March 8, 2020 06:39
@hakman hakman mentioned this pull request Mar 8, 2020
Closed
@hakman
Copy link
Member Author

hakman commented Mar 8, 2020

I don't know Terraform/Cloudformation, so won't be able to lgtm.

No problem. Thanks for checking the texts.

@rifelpet rifelpet mentioned this pull request Mar 16, 2020
Merged
@hakman hakman force-pushed the launch-template-tags-cf-tf branch from 1294d97 to 650df01 Compare March 16, 2020 16:03
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/provider/aws Issues or PRs related to aws provider and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 16, 2020
@hakman hakman force-pushed the launch-template-tags-cf-tf branch from 650df01 to 576e546 Compare March 16, 2020 16:42
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 16, 2020
@hakman @johngmyers
Apply suggestions from code review #1
fb68aae 
Co-Authored-By: John Gardiner Myers <jgmyers@proofpoint.com>
@rifelpet
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2020
@hakman
Copy link
Member Author

hakman commented Mar 16, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 68c2370 into kubernetes:master Mar 16, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 16, 2020
@hakman hakman deleted the launch-template-tags-cf-tf branch March 27, 2020 07:41
@hakman hakman mentioned this pull request Sep 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

@granular-ryanbonham granular-ryanbonham Awaiting requested review from granular-ryanbonham

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hakman @rifelpet @k8s-ci-robot @johngmyers