Update tags support for LaunchTemplates

[hakman]

Launch Templates are the recommended way of creating an ASG in AWS and allows specifying various options that are not possible with Launch Configurations.
https://docs.aws.amazon.com/autoscaling/ec2/userguide/LaunchTemplates.html

This is a followup of #8462 with the following improvements:

• adds remaining cloud tags
• checks for changes before applying new tags

This is a bit more complicated as it has to account Launch Configurations, Mixed Instance Policies and Launch Templates at same time.
A lot of testing is also required to avoid breaking existing features.

@johngmyers as I said during office hours, I am looking into this for some time. If you plan to do any other changes in this area, we should sync so that we don't duplicate the effort.

[johngmyers]

This would be easier to review if the separate concerns were in separate commits.

[johngmyers]

Once we get Terraform and Cloudformation support, I was thinking we'd change the following setting to be false when using launch templates:

kops/upup/pkg/fi/cloudup/awstasks/autoscalinggroup.go

Line 551 in 051ceee

PropagateAtLaunch: aws.Bool(true),

I don't have any changes planned in this area other than seeing if we can change the default value of the EnableLaunchTemplates feature flag.

[hakman]

Separated the CF and TF support for a future PR. This one is pretty easy to review now.

[hakman]

/cc @rifelpet

[hakman]

@rifelpet I think this is finally ready to go. Thanks!

[rifelpet]

hm is CloudTagsForInstanceGroup not used when we target terraform? I would expect some of the terraform integration test files to require updating.

[hakman]

The initial commit contained terraform and cloudformation files also, but I was asked to split them to make it easier to review.
f434b48

[rifelpet]

right, but I would think that CloudTagsForInstanceGroup is used by both "direct" and "terraform" targets. What additional change to the terraform target needs to be made?

Ah, I see that the terraform target doesnt mention tags at all so we'll need to plumb that through before the terraform integration tests require updating. 👍 makes sense now.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hakman]

My general impression with this is that the direct target needs a lot of "love". There are warning during cluster setup (resource order), there are warnings on delete, launch templates are not deleted on cluster delete, ...

Terraform and CF targets also need a bit of tweaking, as they don't seem to work out of the box with EnableLaunchTemplates=true.

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[hakman]

/retest

[hakman]

/retest

[hakman]

/retest