Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ubuntu 20.04 (Focal) #8727

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Mar 11, 2020

Ubuntu 20.04 is close to release and will be the next Ubuntu LTS release.
From Kubernetes point of view, this will be the supported distro with the newest Kernel for some time (Debian 10 and RHEL/CentOS 8 were just released).

Once official stable images are released will add an e2e test for it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2020
@hakman
Copy link
Member Author

hakman commented Mar 11, 2020

/cc @rifelpet

if b.Distribution == distros.DistributionBionic && c.ResolverConfig == nil {
c.ResolverConfig = s("/run/systemd/resolve/resolv.conf")
if c.ResolverConfig == nil {
if b.Distribution == distros.DistributionBionic || b.Distribution == distros.DistributionFocal {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of interest, do you know that this was needed? I was hoping they might have fixed it!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a more general issue for distros that enable DNS cache via systemd-resolved, so not sure it can be fixed. Without this CoreDNS keeps complaining about a DNS loop:
https://github.com/coredns/coredns/blob/master/plugin/loop/README.md#troubleshooting-loops-in-kubernetes-clusters

@justinsb
Copy link
Member

Thanks @hakman

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1400528 into kubernetes:master Mar 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 11, 2020
@hakman hakman deleted the ubuntu-focal branch March 15, 2020 16:44
k8s-ci-robot added a commit that referenced this pull request Apr 16, 2020
…pstream-release-1.17

Automated cherry pick of #8727: Add support for Ubuntu 20.04 (Focal)
k8s-ci-robot added a commit that referenced this pull request Apr 24, 2020
…pstream-release-1.16

Automated cherry pick of #8727: Add support for Ubuntu 20.04 (Focal)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants