Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #8727: Add support for Ubuntu 20.04 (Focal) #8925

Conversation

hakman
Copy link
Member

@hakman hakman commented Apr 16, 2020

Cherry pick of #8727 on release-1.16.

#8727: Add support for Ubuntu 20.04 (Focal)

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Apr 16, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 16, 2020
@hogepodge
Copy link

Would it be possible to include support for 19.10 also?

@hakman
Copy link
Member Author

hakman commented Apr 19, 2020

@hogepodge usually we don't support non-LTS versions of Ubuntu.
Any special reason to add support 19.10?

@hogepodge
Copy link

The new Calico eBPF dataplane is being developed and tested against 19.10, which has a supported kernel. I could see how things are working with 20.04 though.

@hakman
Copy link
Member Author

hakman commented Apr 19, 2020

Ah, that makes sense. I read the requirements for the tech preview.
If you could check agains 20.04, would be great. Please let me know how things go.

@hogepodge
Copy link

I tried to bring am Ubuntu 20.04 cluster up, using a nightly build, on AWS using the kops/master branch. nodeup fails, saying it found an unknown version of Debian.

@hakman
Copy link
Member Author

hakman commented Apr 21, 2020

@hogepodge that is because it probably uses an old version of NodeUp. By nightly build I guess you mean you built it yourself?
If that is so, you could try running the latest version manually. This builds, uploads and runs it via SSH:

make push-aws-run TARGET=user@host

Copy link
Member

@geojaz geojaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2020
@geojaz
Copy link
Member

geojaz commented Apr 24, 2020

If there's still interest in 19.10 support, I think we can address that in a later PR. thanks @hakman 😎

@geojaz
Copy link
Member

geojaz commented Apr 24, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geojaz, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1938652 into kubernetes:release-1.16 Apr 24, 2020
@hakman
Copy link
Member Author

hakman commented Apr 25, 2020

Thanks @geojaz :)

@hakman
Copy link
Member Author

hakman commented May 8, 2020

@hogepodge I checked that latest Kops releases can create a cluster with Ubuntu 20.04 and the bundled Calico v3.13.3. I hope that works ok for the eBPF dataplane also.

@hakman hakman deleted the automated-cherry-pick-of-#8727-upstream-release-1.16 branch June 2, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants