fixes auth problem in case of openstack kops-controller

[zetaab]

fixes #8861 (openstack part hopefully)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zetaab]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hakman]

/lgtm

[mitch000001]

@zetaab Can you confirm that the errors in the logs vanished/the node labels are back in place?
And also, can we backport this to the stable versions out there? I guess this will affect a lot of people

[zetaab]

@mitch000001 yes everything works fine now. We can backport this

[kciredor]

This was merged into 1.17.2, but I'm afraid I'm getting hit by "Authentication failed" issues.

gophercloud ReAuth default false... I mean... 👎 Now it's fixed for etcd-controller and supposedly for kops-controller but these are the logs many times per minute:

E0915 08:48:02.481845 1 controller.go:218] controller-runtime/controller "msg"="Reconciler error" "error"="unable to load cluster object for node nodes-4-xxx-k8s-local: error loading Cluster "swift://xxx/xxx.k8s.local/cluster.spec": error reading swift://xxx/xxx.k8s.local/cluster.spec: Authentication failed" "controller"="node" "request"={"Namespace":"","Name":"nodes-4-xxx-k8s-local"}

[mitch000001]

So basically the issue is related to the Swift state store client which gets used by the controller. I guess it also needs the reauth setting but the location is probably not within the kops-controller itself but rather within kops code of the state store authentication.
Can you please open another issue where you describe the error so it gets the awareness it should get?