fixes(openstack): auth problem for kops-controller

[ghost]

Cherry pick of #8862 to be used in 1.17

[k8s-ci-robot]

Hi @xcalizorz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ghost]

/assign @justinsb

[johngmyers]

/ok-to-test

[ghost]

/retest

[ghost]

@zetaab Could you review this, please?

[ghost]

@zetaab Could you check again, please?

[olemarkus]

Looks like make govet is still failing.

[ghost]

Looks like make govet is still failing.

I removed the commit, because it was not related to the openstack issue

[olemarkus]

The pull-kops-verify-govet check still fails though.

[ghost]

The pull-kops-verify-govet check still fails though.

Yes I know, it fails because of the line in upup/pkg/fi/cloudup/awsup/machine_types.go. I can reintroduce the change if you like, but it will be a change that's not related to this issue.

# k8s.io/kops/upup/pkg/fi/cloudup/awsup
upup/pkg/fi/cloudup/awsup/machine_types.go:58:30: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)

[hakman]

Once #9752 is merged, the test will pass.
@zetaab I guess this is important enough to require a new release?

[zetaab]

@xcalizorz can you rebase this, tests should start working now

[hakman]

/test pull-kops-verify-govet

[hakman]

@xcalizorz Merges are not allowed, just rebase.

[hakman]

/lgtm

[zetaab]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Xcalizorz, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zetaab]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment