Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for func matchesElbTags #8989

Merged
merged 1 commit into from
May 20, 2020
Merged

Add unit test for func matchesElbTags #8989

merged 1 commit into from
May 20, 2020

Conversation

hs0210
Copy link
Contributor

@hs0210 hs0210 commented Apr 26, 2020

Signed-off-by: Hu Shuai hus.fnst@cn.fujitsu.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @hs0210. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2020
@hakman
Copy link
Member

hakman commented Apr 26, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 26, 2020
@hs0210
Copy link
Contributor Author

hs0210 commented Apr 26, 2020

/retest

2 similar comments
@hs0210
Copy link
Contributor Author

hs0210 commented Apr 26, 2020

/retest

@hs0210
Copy link
Contributor Author

hs0210 commented Apr 26, 2020

/retest

olemarkus
olemarkus reviewed Apr 26, 2020
View reviewed changes
pkg/resources/aws/aws_test.go Outdated
}
}

func strtopoint(str string) *string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have fi.String that does the same thing.

@hs0210
Copy link
Contributor Author

hs0210 commented Apr 26, 2020

@olemarkus I have replaced the func strtopoint with fi.String. PTAL.

@olemarkus
Copy link
Member

Can you fix te bazel test? probably enough to run hack/update-bazel.sh
Looks good otherwise.

hakman
hakman requested changes Apr 26, 2020
View reviewed changes
pkg/resources/aws/aws_test.go Outdated
expected bool
}{
{
tags: strtomap("tagkey1", "tagvalue1"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use strtomap when you could directly create a map?

Suggested change
tags: strtomap("tagkey1", "tagvalue1"),
tags: map[string]string{"tagkey1": "tagvalue1"}

@hs0210
Copy link
Contributor Author

hs0210 commented Apr 27, 2020

@hakman Thanks.

@hs0210
Copy link
Contributor Author

hs0210 commented Apr 27, 2020

@olemarkus Sorry, can you explain a little more, I am not very clear what I need to fix.

@hakman
Copy link
Member

hakman commented Apr 27, 2020

Happy to help @hs0210. Could you also add some tests for multiple tags? The matchesElbTags function should handle those also. Thanks!

@olemarkus asked that you run hack/update-bazel.sh and commit the changes to fix the 2 failing tests.

@hs0210
Add unit test for func matchesElbTags
bf83440 
Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>
@hs0210
Copy link
Contributor Author

hs0210 commented Apr 28, 2020

@hakman I see these tags are all in string format, don't they?

@hs0210
Copy link
Contributor Author

hs0210 commented May 12, 2020

PTAL.

@hakman
Copy link
Member

hakman commented May 12, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2020
@rifelpet
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hs0210, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 83c2a08 into kubernetes:master May 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus left review comments

@hakman hakman hakman requested changes

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hs0210 @k8s-ci-robot @hakman @olemarkus @rifelpet