Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for func matchesElbTags #8989

Merged
merged 1 commit into from
May 20, 2020
Merged

Add unit test for func matchesElbTags #8989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/resources/aws/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,11 @@ go_test(
"//cloudmock/aws/mockec2:go_default_library",
"//pkg/resources:go_default_library",
"//pkg/testutils:go_default_library",
"//upup/pkg/fi:go_default_library",
"//upup/pkg/fi/cloudup/awsup:go_default_library",
"//upup/pkg/fi/utils:go_default_library",
"//vendor/github.com/aws/aws-sdk-go/aws:go_default_library",
"//vendor/github.com/aws/aws-sdk-go/service/ec2:go_default_library",
"//vendor/github.com/aws/aws-sdk-go/service/elb:go_default_library",
],
)
60 changes: 60 additions & 0 deletions pkg/resources/aws/aws_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ import (

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/ec2"
"github.com/aws/aws-sdk-go/service/elb"
"k8s.io/kops/cloudmock/aws/mockec2"
"k8s.io/kops/pkg/resources"
"k8s.io/kops/upup/pkg/fi"
"k8s.io/kops/upup/pkg/fi/cloudup/awsup"
)

Expand Down Expand Up @@ -196,3 +198,61 @@ func TestSharedVolume(t *testing.T) {
}
}
}

func TestMatchesElbTags(t *testing.T) {
tc := []struct {
tags map[string]string
actual []*elb.Tag
expected bool
}{
{
tags: map[string]string{"tagkey1": "tagvalue1"},
actual: []*elb.Tag{
{
Key: fi.String("tagkey1"),
Value: fi.String("tagvalue1"),
},
{
Key: fi.String("tagkey2"),
Value: fi.String("tagvalue2"),
},
},
expected: true,
},
{
tags: map[string]string{"tagkey2": "tagvalue2"},
actual: []*elb.Tag{
{
Key: fi.String("tagkey1"),
Value: fi.String("tagvalue1"),
},
{
Key: fi.String("tagkey2"),
Value: fi.String("tagvalue2"),
},
},
expected: true,
},
{
tags: map[string]string{"tagkey3": "tagvalue3"},
actual: []*elb.Tag{
{
Key: fi.String("tagkey1"),
Value: fi.String("tagvalue1"),
},
{
Key: fi.String("tagkey2"),
Value: fi.String("tagvalue2"),
},
},
expected: false,
},
}

for i, test := range tc {
got := matchesElbTags(test.tags, test.actual)
if got != test.expected {
t.Fatalf("unexpected result from testcase %d, expected %v, got %v", i, test.expected, got)
}
}
}