Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try github actions failure to see if PRs can't be merged #9015

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

rifelpet
Copy link
Member

Ref: #9005

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2020
@rifelpet rifelpet changed the title WIP try github actions failures to see if PRs can't be merged WIP try github actions failure to see if PRs can't be merged Apr 28, 2020
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 11, 2020
@rifelpet rifelpet changed the title WIP try github actions failure to see if PRs can't be merged try github actions failure to see if PRs can't be merged Jun 11, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 11, 2020
@rifelpet
Copy link
Member Author

@mikesplain would prow merge this if it had a lgtm label? looking at the tide details, it seems like it would but i'd expect it not to.

@hakman
Copy link
Member

hakman commented Jun 18, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2020
@rifelpet
Copy link
Member Author

🥁
the tide page isn't mentioning the GHA failures but i guess we'll see if it is able to merge it or not. I'm guessing not given that the GHA jobs now have the Required label on them.

If it can't merge it, then we can close this and proceed with #9005

@k8s-ci-robot k8s-ci-robot merged commit 793e3cf into kubernetes:master Jun 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 18, 2020
@rifelpet
Copy link
Member Author

:(

@mikesplain
Copy link
Contributor

Right... I think because prow doesn't know about them... which is why https://github.com/kubernetes/test-infra/pull/17917/files#diff-00deeeaf0a7a2aba7d06744db0da6d43R535-R536 is needed.

@hakman
Copy link
Member

hakman commented Jun 18, 2020

@rifelpet
Copy link
Member Author

that seems strange because the GHA jobs are now showing as "required" in the list of statuses:

Screen Shot 2020-06-17 at 11 24 52 PM

so i would think that GH wouldn't let prow merge the PR even if it wanted to... ah well, we can resume this when you get a chance to test more on your internal prow

@mikesplain
Copy link
Contributor

Unknown contexts didn't work as expected when I tested it.

Tide doesn't do a github merge afaik. It does it all via git commands essentially. But tide blocks on jobs it knows about and, when configured, protected branch rules.

I'll revisit that PR later in the week to see if I can figure it out. Next time I wish we could get some logs before immediately reverting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants