-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try github actions failure to see if PRs can't be merged #9015
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mikesplain would prow merge this if it had a lgtm label? looking at the tide details, it seems like it would but i'd expect it not to. |
/lgtm |
:( |
Right... I think because prow doesn't know about them... which is why https://github.com/kubernetes/test-infra/pull/17917/files#diff-00deeeaf0a7a2aba7d06744db0da6d43R535-R536 is needed. |
Do we want also to skip unknown contexts? |
Unknown contexts didn't work as expected when I tested it. Tide doesn't do a github merge afaik. It does it all via git commands essentially. But tide blocks on jobs it knows about and, when configured, protected branch rules. I'll revisit that PR later in the week to see if I can figure it out. Next time I wish we could get some logs before immediately reverting. |
Ref: #9005