Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cluster maintenance when channel is unavailable #9053

Merged
merged 1 commit into from
May 6, 2020

Conversation

johngmyers
Copy link
Member

Addresses some aspects of #8834, assuming no instancegroup is depending on the channel providing a default image to use.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 3, 2020
@johngmyers
Copy link
Member Author

/retest

@hakman
Copy link
Member

hakman commented May 4, 2020

Really nice. I would see this cherry-picked to all live branches that will get the etcd-manager fix.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2020
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for this @johngmyers!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 486c20f into kubernetes:master May 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 6, 2020
@johngmyers johngmyers deleted the channels-dependency branch May 6, 2020 14:44
k8s-ci-robot added a commit that referenced this pull request May 6, 2020
…53-upstream-release-1.17

Automated cherry pick of #9053: Allow cluster maintenance when channel is unavailable
k8s-ci-robot added a commit that referenced this pull request May 13, 2020
…53-upstream-release-1.16

Automated cherry pick of #9053: Allow cluster maintenance when channel is unavailable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants