-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openstack): propagate cloud labels to machines #9211
feat(openstack): propagate cloud labels to machines #9211
Conversation
Hi @mitch000001. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mitch000001 did you test this by deploying new cluster? I am just worried that we do not see problems again
@zetaab I successfully created a cluster with these changes in our Openstack environment. All tags were propagated successfully. And the cluster is valid. |
1c3ddf2
to
42cbede
Compare
@zetaab @olemarkus I think this got stuck somehow, as I see it was already approved. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, mitch000001 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Although there are no conflicts with master, should I rebase/merge it in once more? |
Should be ok without rebasing. If you don't mind, maybe give a try to the master branch once it's merged. |
@mitch000001 I think you were right. It needs rebase because of the change to Go 1.15. |
👍 |
42cbede
to
df5cc6a
Compare
/lgtm |
Fixes #9086