-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Digital Ocean] Update RBAC for DO CCM #9249
Conversation
Hi @srikiz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@hakman: GitHub didn't allow me to request PR reviews from the following users: timoreimann. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from DigitalOcean perspective. 👍
For context: this fixes an issue with DO's cloud-controller-manager not being able to use leases due to missing RBAC permissions.
Thanks @timoreimann . |
/retest |
/approve We'll probably want to cherry-pick this back to at least release-1.18 and I'm guessing release-1.17 to match where #9179 was cherry-picked? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet, srikiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@srikiz I think this should be cherry-picked to 1.18 and maybe 1.17 (if it is affected). |
yes @hakman - It needs to be cherry-picked for both 1.17 and 1.18 - I'll raise PR's today. Thanks ! |
Thank you also for taking care of this |
…pstream-release-1.17 Automated cherry pick of #9249: update RBAC for DO CCM
…pstream-release-1.18 Automated cherry pick of #9249: update RBAC for DO CCM
Fixes RBAC for DO CCM.
Tested with the below change and ensured the cluster now comes up Ok.