Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Digital Ocean] Update RBAC for DO CCM #9249

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

srikiz
Copy link
Contributor

@srikiz srikiz commented Jun 2, 2020

Fixes RBAC for DO CCM.
Tested with the below change and ensured the cluster now comes up Ok.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 2, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @srikiz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@srikiz srikiz changed the title [Digital Ocean} Update RBAC for DO CCM [Digital Ocean] Update RBAC for DO CCM Jun 2, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 2, 2020
@hakman
Copy link
Member

hakman commented Jun 2, 2020

/ok-to-test
/cc timoreimann

@k8s-ci-robot
Copy link
Contributor

@hakman: GitHub didn't allow me to request PR reviews from the following users: timoreimann.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/ok-to-test
/cc timoreimann

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 2, 2020
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from DigitalOcean perspective. 👍

For context: this fixes an issue with DO's cloud-controller-manager not being able to use leases due to missing RBAC permissions.

@hakman
Copy link
Member

hakman commented Jun 2, 2020

Thanks @timoreimann .
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2020
@hakman
Copy link
Member

hakman commented Jun 2, 2020

/retest

@rifelpet
Copy link
Member

rifelpet commented Jun 2, 2020

/approve

We'll probably want to cherry-pick this back to at least release-1.18 and I'm guessing release-1.17 to match where #9179 was cherry-picked?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, srikiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 751e9ea into kubernetes:master Jun 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jun 2, 2020
@rifelpet rifelpet modified the milestones: v1.18, v1.19 Jun 2, 2020
@hakman
Copy link
Member

hakman commented Jun 3, 2020

@srikiz I think this should be cherry-picked to 1.18 and maybe 1.17 (if it is affected).

@srikiz
Copy link
Contributor Author

srikiz commented Jun 3, 2020

yes @hakman - It needs to be cherry-picked for both 1.17 and 1.18 - I'll raise PR's today. Thanks !

@srikiz srikiz deleted the DO-Fix-CCM-RBAC branch June 3, 2020 06:29
@hakman
Copy link
Member

hakman commented Jun 3, 2020

Thank you also for taking care of this

k8s-ci-robot added a commit that referenced this pull request Jun 3, 2020
…pstream-release-1.17

Automated cherry pick of #9249: update RBAC for DO CCM
k8s-ci-robot added a commit that referenced this pull request Jun 3, 2020
…pstream-release-1.18

Automated cherry pick of #9249: update RBAC for DO CCM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants