Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SECURITY_CONTACTS #9627

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Update SECURITY_CONTACTS #9627

merged 1 commit into from
Aug 10, 2020

Conversation

johngmyers
Copy link
Member

@johngmyers johngmyers commented Jul 25, 2020 •
edited by zetaab
Loading

Update SECURITY_CONTACTS to the current set of approvers.

Before merging, each of the following people should comment that they agree to abide by the Embargo Policy:

I agree to abide by the Embargo Policy.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2020
@hakman
Copy link
Member

hakman commented Jul 25, 2020

I agree to abide by the Embargo Policy.

3 similar comments
@KashifSaadat
Copy link
Contributor

I agree to abide by the Embargo Policy.

@rdrgmnzs
Copy link
Contributor

I agree to abide by the Embargo Policy.

@rifelpet
Copy link
Member

I agree to abide by the Embargo Policy.

@geojaz
Copy link
Member

geojaz commented Jul 28, 2020

@zetaab Could you pls add your acceptance of the embargo policy? It looks like we can finalize this once you have! thanks

@hakman
Copy link
Member

hakman commented Jul 31, 2020

@johngmyers should we merge as is and add @zetaab at a later time?

@johngmyers
Copy link
Member Author

I don't think there's a rush to get this merged. We can wait.

@zetaab
Copy link
Member

zetaab commented Aug 10, 2020

I agree to abide by the Embargo Policy.

@hakman
Copy link
Member

hakman commented Aug 10, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2020
@johngmyers johngmyers changed the title WIP Update SECURITY_CONTACTS Update SECURITY_CONTACTS Aug 10, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4dcc8c6 into kubernetes:master Aug 10, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 10, 2020
@johngmyers johngmyers deleted the update-contacts branch August 10, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
8 participants
@johngmyers @k8s-ci-robot @hakman @KashifSaadat @rdrgmnzs @rifelpet @geojaz @zetaab