Add roycaihw to reviewer and update test README

kubernetes · Oct 15, 2018 · 3809d15 · 3809d15
1 parent 9dfdf9b
commit 3809d15
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/OWNERS b/OWNERS
@@ -5,6 +5,7 @@ reviewers:
 - philips
 - seans3
 - apelisse
+- roycaihw
 approvers:
 - mbohlool
 - lavalamp

diff --git a/pkg/generators/rules/OWNERS b/pkg/generators/rules/OWNERS
@@ -0,0 +1,4 @@
+reviewers:
+- roycaihw
+approvers:
+- roycaihw
diff --git a/test/integration/README.md b/test/integration/README.md
@@ -29,3 +29,12 @@ the current directory.
 ```bash
 $ go run builder/main.go testdata/golden.json
 ```
+
+After the golden spec is generated, please clean up the generated file
+`pkg/generated/openapi_generated.go` before you commit. It's an intermediate product that doesn't need to be updated in kube-openapi repository. The checked-in file is kept minimum to make sure that `test/integration/builder` compiles. Please run:
+
+```base
+$ git checkout pkg/generated/openapi_generated.go
+```
+
+to discard any local change.