-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for ReclaimPolicy, VolumeBindingMode storageclass metrics. #929
Conversation
Welcome @clickyotomy! |
Thanks for your PR @clickyotomy! I've provided my comments. Please make sure to squash your commits as well. |
Thanks, @tariq1890! I've made the changes you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks so much :) @clickyotomy
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clickyotomy, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: Checks for
nil
*StorageClass.{ReclaimPolicy, VolumeBindingMode}
fields and add default values for them. This should prevent segmentation faults from occurring.Which issue(s) this PR fixes: Fixes #899.